[wsf-c-dev] [PHP] WSDL generation PHP scripts - few thoughts

[Samisa Abeysinghe]

The prefix used for class names is WS_Wsdl. I think it is better to have 
either WS_WSDL or WSWSDL. I prefer former as that is more readable.

Samisa...

Samisa Abeysinghe wrote:
> 1. Code indentation is terrible. We must use a coding convention for 
> PHP scripts. I propose that we use: 
> http://framework.zend.com/manual/en/coding-standard.coding-style.html
>
> 2. Doc comments in the code are missing. Classes/methods/functions 
> need to be documented. Again we should follow the conventions in the 
> coding guideline given above.
>
> 3. The scripts use "include"; I suggest that we use include_once instead.
>
> 4. Shall we move all WSDL generation related PHP scripts to a wsdl sub 
> folder within scripts?
> It looks messy to have it at the same level as wsf.php.
>
> 5. Shall we include WS_WsdlCreator.php in wsf.php and use wsf.php in 
> the C code, rather than using WS_WsdlCreator.php? That may look more 
> tidy.
>
> Thanks,
> Samisa...
>
>
> _______________________________________________
> Wsf-c-dev mailing list
> Wsf-c-dev at wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/wsf-c-dev
>


-- 
Samisa Abeysinghe : http://www.wso2.org/ (WSO2 Oxygen Tank - Web Services Developers' Portal)