[wsf-c-dev] [PHP] WSDL generation PHP scripts - few thoughts

Samisa Abeysinghe samisa at wso2.com
Mon Feb 5 18:28:09 PST 2007


1. Code indentation is terrible. We must use a coding convention for PHP 
scripts. I propose that we use: 
http://framework.zend.com/manual/en/coding-standard.coding-style.html

2. Doc comments in the code are missing. Classes/methods/functions need 
to be documented. Again we should follow the conventions in the coding 
guideline given above.

3. The scripts use "include"; I suggest that we use include_once instead.

4. Shall we move all WSDL generation related PHP scripts to a wsdl sub 
folder within scripts?
It looks messy to have it at the same level as wsf.php.

5. Shall we include WS_WsdlCreator.php in wsf.php and use wsf.php in the 
C code, rather than using WS_WsdlCreator.php? That may look more tidy.

Thanks,
Samisa...





More information about the Wsf-c-dev mailing list