[Registry-dev] svn commit r14559 - in trunk/registry/modules/core/src/main: java/org/wso2/registry/users/def java/org/wso2/registry/users/def/util resources/database-scripts

[Dimuthu Leelarathne]

Hi Glen,

I will break the line on if 100ch from here onwards :)

I have set eclipse to break lines at 80ch. And in this specific line I
think the problem is something else.

I will revert all the line breaks < 100ch.

Sorry about it.

Thank you,
Dimuthu


On Thu, 2008-03-06 at 11:28 -0500, Glen Daniels wrote:
> Hi Dimuthu:
> 
> OK, it's probably time to have the code formatting discussion again. :)
> 
> I noticed stuff like this in your commit:
> 
> > -                throw new UserStoreException(Messages.getMessage("null_connection"));
> > +                throw new UserStoreException(Messages
> > +                        .getMessage("null_connection"));
> 
> Unless the line is too long (i.e. > 100ch) we really shouldn't be 
> breaking these calls - the way it was is much more readable than the 
> changed version.
> 
> Is everyone using IDEA on the Registry?  If so, I've checked in the code 
> formatting template I've been using under project/.  Please take a look 
> and confirm that it matches yours - if there are differences, let's discuss.
> 
> If people are using Eclipse as well, let's try to make sure the exact 
> same settings are checked in for that too?
> 
> Thanks,
> --Glen
> 
> _______________________________________________
> Registry-dev mailing list
> Registry-dev at wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/registry-dev