[Registry-dev] svn commit r14559 - in trunk/registry/modules/core/src/main: java/org/wso2/registry/users/def java/org/wso2/registry/users/def/util resources/database-scripts

Glen Daniels glen at wso2.com
Thu Mar 6 08:28:30 PST 2008


Hi Dimuthu:

OK, it's probably time to have the code formatting discussion again. :)

I noticed stuff like this in your commit:

> -                throw new UserStoreException(Messages.getMessage("null_connection"));
> +                throw new UserStoreException(Messages
> +                        .getMessage("null_connection"));

Unless the line is too long (i.e. > 100ch) we really shouldn't be 
breaking these calls - the way it was is much more readable than the 
changed version.

Is everyone using IDEA on the Registry?  If so, I've checked in the code 
formatting template I've been using under project/.  Please take a look 
and confirm that it matches yours - if there are differences, let's discuss.

If people are using Eclipse as well, let's try to make sure the exact 
same settings are checked in for that too?

Thanks,
--Glen



More information about the Registry-dev mailing list