[Registry-dev] svn commit r11305 - in trunk/registry/modules/core/src/main: java/org/wso2/registry/app java/org/wso2/registry/config java/org/wso2/registry/servlet resources resources/org/wso2/registry/i18n

Deepal Jayasinghe deepal at wso2.com
Tue Dec 18 00:06:02 PST 2007


Done,
Actually I had the method signature you proposed but I changed that
immediately before I commit :)

Thanks
Deepal
> svn at wso2.org wrote:
>> +    public void exportToRegistry(File file, String path) throws
>> RegistryException {
>> +        try {
>> +            processImport(file, path);
>> +        } catch (Exception e) {
>> +            e.printStackTrace();
>> +            throw new RegistryException(e.getMessage());
>> +        }
>> +    }
>
> Please rename the above method "import".
>
>> +    public void importFromRegistry(File toFile, String path) throws
>> RegistryException {
>> +        try {
>> +            processExport(path, toFile);
>> +        } catch (Exception e) {
>> +            e.printStackTrace();
>> +            throw new RegistryException(e.getMessage());
>> +        }
>> +    }
>
> Please rename the above method "export".
>
> The current names don't make sense ... having a method named
> importFromRegistry calling processExport is the hint ;-).
>
> Sanjiva.





More information about the Registry-dev mailing list