[mashup-dev] [jira] Commented: (MASHUP-272) Error in ?tryit when .serviceName has numbers

[Jonathan Marsh (JIRA)]

    [ http://www.wso2.org/jira/browse/MASHUP-272?page=comments#action_12318 ] 
            
Jonathan Marsh commented on MASHUP-272:
---------------------------------------

I base the stubs off of (valid) WSDL.  The name "1versionSimple" is not an NCName, and results in invalid QNames for the service name, and other names based off it like binding names, interface names, and so forth.  Since the ?wsdl of this service is invalid, I'm reassigning it to you, even though the WSDL validity doesn't solve related issue MASHUP-199.

We could pursue two approaches, automatic rewriting or encoding of names to conform to WSDL, and furthermore to Javascript, names.  Or we could impose a restriction that service and operation names must be both valid NCNames and valid Javascript names (and valid URI paths for that matter, though I think that's already covered). The first option, rewriting, sounds confusing to me, as users are likely to lose track of which name is used where.  Users would be advised for their own sanity to choose names that can transfer between scopes (it's not all that hard), and it would simplify our life, and in the long run the user's, to impose this restriction from the start.

The intersection of NCNames and Javascript names (for characters under xFF anyway) is the same as NCName, minus hyphens and periods.  There are some combining character differences farther up the Unicode table but this would catch most of the problems initially. I think we could make a global decision to allow all characters over xFF as users of these characters presumeably will know what they need to do.

In sum, I'm proposing we reject and mashup .js filename, any function name, or any .serviceName or .operationName that doesn't conform to this set of characters:

  Initial character: [#x003A] | [#x0041-#x005A] | [#x005F] | [#x0061-#x007A] | [#x00C0-#x00D6] | [#x00D8-#x00F6] | [#x00F8-...])
  Non-start character: initial characters + [#x0030-#x0039] 

Thoughts on my proposed strange but practical mixture of heavy constraints on the low end and free-for-all on the top end?


> Error in ?tryit when .serviceName has numbers
> ---------------------------------------------
>
>                 Key: MASHUP-272
>                 URL: http://www.wso2.org/jira/browse/MASHUP-272
>             Project: WSO2 Mashup Server
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.1
>         Environment: WinXP, JDK1.5, FF2.0.0.6
>            Reporter: Yumani Ranaweera
>         Assigned To: Keith Godwin Chapman
>             Fix For: 0.2
>
>
> Steps to recreate:
> ---------------------
> 1. Create and deploy a service using the source below;
> this.serviceName = "1versionSimple";
> getVersion.inputTypes = {};
> getVersion.outputType = "any";
> function getVersion(){
>         return ("The version of the Mashup Server is SNAPSHOT");
> }
> 2. Check the ?tryit of the service (https://localhost:7443/services/versionSimple?tryit)
> Issue:
> -------
>  - Choose endpoint box cannot be expanded.
>  - The button with 'operation name' doesn't appear.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://www.wso2.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira